RTF: Fix Header.php registerFont() not registering fonts/colors in subElements (such as textRuns) #2818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
registerFont() registered fonts and colors from sections, but not from subparts of sections, such as textruns.
rasamassen
changed the title
|
I don't understand why this is failing the Static Analysis. I'm not sure what codebase you're using for that, but it sounds a lot like the issue described here: phpstan/phpstan#4579. I don't think this should be failing Static Analysis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
registerFont() registered fonts and colors from sections, but not from subparts of sections, such as textruns.
Description
Now the header registers every font and color in a textRun. This is important if the fonts and colors are actually going to be used.
Fixes # (issue)
Checklist: